]> dgit.raspbian.org Git - gnome-shell.git/commit
workspace: Fix an incorrect signal check
authorJonas Dreßler <verdre@v0yd.nl>
Fri, 20 Sep 2019 09:37:26 +0000 (11:37 +0200)
committerJonas Dreßler <verdre@v0yd.nl>
Fri, 20 Sep 2019 09:50:24 +0000 (11:50 +0200)
commit48adb2ef4b3fa97c59952ca45918268e1e2d0160
tree323cd5255efaf1be6c189c2cf2d65fe36ab7e7bb
parentf8e648b7e35e0acef5f922fc64164caa7bdd46e3
workspace: Fix an incorrect signal check

While commit 3094f863 was intended to cancel the ongoing idle hide
timeout before we start a new one, a mistake slipped in there while
rebasing: Obviously we should check if the signal id is NOT 0 here.

This didn't prevent timeouts being started while old ones are still
running and did override `this._idleHideOverlayId`, which caused the old
timeouts to run indefinitely after an overlay actor was destroyed
because we fail early (and don't return TRUE) in `_idleHideOverlay()`.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/735
js/ui/workspace.js